mirrors/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2026-01-22 22:52:20 +08:00
Code Issues Packages Projects Releases 2 Wiki Activity

ID: 3577159 - 'lib/ipmi_sdr.c' - uint32_t cast to uint8_t and back

Browse Source 
Commit removes pointless(?) and unhandled cast from uint32_t to uint8_t and
back. intf->target_addr is uint32_t, don't try to "squeeze" it into uint8_t
then.

Reported by: Duncan Idaho
This commit is contained in:
Zdenek Styblik 2012-11-11 18:59:36 +00:00
parent 5b90f68407
commit 8d9b434b5a
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ipmitool/lib/ipmi_sdr.c
View File

@ -454,8 +454,8 @@ ipmi_sdr_get_sensor_thresholds(struct ipmi_intf *intf, uint8_t sensor,
{ {
struct ipmi_rq req; struct ipmi_rq req;
struct ipmi_rs *rsp; struct ipmi_rs *rsp;
uint8_t save_addr; uint32_t save_addr;
uint8_t save_channel; uint32_t save_channel;
save_addr = intf->target_addr; save_addr = intf->target_addr;
intf->target_addr = target; intf->target_addr = target;
@ -491,8 +491,8 @@ ipmi_sdr_get_sensor_hysteresis(struct ipmi_intf *intf, uint8_t sensor,
struct ipmi_rq req; struct ipmi_rq req;
uint8_t rqdata[2]; uint8_t rqdata[2];
struct ipmi_rs *rsp; struct ipmi_rs *rsp;
uint8_t save_addr; uint32_t save_addr;
uint8_t save_channel; uint32_t save_channel;
save_addr = intf->target_addr; save_addr = intf->target_addr;
intf->target_addr = target; intf->target_addr = target;
@ -551,8 +551,8 @@ ipmi_sdr_get_sensor_reading_ipmb(struct ipmi_intf *intf, uint8_t sensor,
{ {
struct ipmi_rq req; struct ipmi_rq req;
struct ipmi_rs *rsp; struct ipmi_rs *rsp;
uint8_t save_addr; uint32_t save_addr;
uint8_t save_channel; uint32_t save_channel;
#if 0 #if 0
/* Enabling this code will cause sensors with an SDR Owner ID /* Enabling this code will cause sensors with an SDR Owner ID
@ -598,8 +598,8 @@ ipmi_sdr_get_sensor_event_status(struct ipmi_intf *intf, uint8_t sensor,
{ {
struct ipmi_rq req; struct ipmi_rq req;
struct ipmi_rs *rsp; struct ipmi_rs *rsp;
uint8_t save_addr; uint32_t save_addr;
uint8_t save_channel; uint32_t save_channel;
save_addr = intf->target_addr; save_addr = intf->target_addr;
intf->target_addr = target; intf->target_addr = target;
@ -634,8 +634,8 @@ ipmi_sdr_get_sensor_event_enable(struct ipmi_intf *intf, uint8_t sensor,
{ {
struct ipmi_rq req; struct ipmi_rq req;
struct ipmi_rs *rsp; struct ipmi_rs *rsp;
uint8_t save_addr; uint32_t save_addr;
uint8_t save_channel; uint32_t save_channel;
save_addr = intf->target_addr; save_addr = intf->target_addr;
intf->target_addr = target; intf->target_addr = target;