From 8d9b434b5a575933753e535ab520902402890418 Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Sun, 11 Nov 2012 18:59:36 +0000 Subject: [PATCH] ID: 3577159 - 'lib/ipmi_sdr.c' - uint32_t cast to uint8_t and back Commit removes pointless(?) and unhandled cast from uint32_t to uint8_t and back. intf->target_addr is uint32_t, don't try to "squeeze" it into uint8_t then. Reported by: Duncan Idaho --- ipmitool/lib/ipmi_sdr.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/ipmitool/lib/ipmi_sdr.c b/ipmitool/lib/ipmi_sdr.c index 9f97a15..ebbfd84 100644 --- a/ipmitool/lib/ipmi_sdr.c +++ b/ipmitool/lib/ipmi_sdr.c @@ -454,8 +454,8 @@ ipmi_sdr_get_sensor_thresholds(struct ipmi_intf *intf, uint8_t sensor, { struct ipmi_rq req; struct ipmi_rs *rsp; - uint8_t save_addr; - uint8_t save_channel; + uint32_t save_addr; + uint32_t save_channel; save_addr = intf->target_addr; intf->target_addr = target; @@ -491,8 +491,8 @@ ipmi_sdr_get_sensor_hysteresis(struct ipmi_intf *intf, uint8_t sensor, struct ipmi_rq req; uint8_t rqdata[2]; struct ipmi_rs *rsp; - uint8_t save_addr; - uint8_t save_channel; + uint32_t save_addr; + uint32_t save_channel; save_addr = intf->target_addr; intf->target_addr = target; @@ -551,8 +551,8 @@ ipmi_sdr_get_sensor_reading_ipmb(struct ipmi_intf *intf, uint8_t sensor, { struct ipmi_rq req; struct ipmi_rs *rsp; - uint8_t save_addr; - uint8_t save_channel; + uint32_t save_addr; + uint32_t save_channel; #if 0 /* Enabling this code will cause sensors with an SDR Owner ID @@ -598,8 +598,8 @@ ipmi_sdr_get_sensor_event_status(struct ipmi_intf *intf, uint8_t sensor, { struct ipmi_rq req; struct ipmi_rs *rsp; - uint8_t save_addr; - uint8_t save_channel; + uint32_t save_addr; + uint32_t save_channel; save_addr = intf->target_addr; intf->target_addr = target; @@ -634,8 +634,8 @@ ipmi_sdr_get_sensor_event_enable(struct ipmi_intf *intf, uint8_t sensor, { struct ipmi_rq req; struct ipmi_rs *rsp; - uint8_t save_addr; - uint8_t save_channel; + uint32_t save_addr; + uint32_t save_channel; save_addr = intf->target_addr; intf->target_addr = target;