mirrors/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2026-01-22 22:52:20 +08:00
Code Issues Packages Projects Releases 2 Wiki Activity

Fix big parameter passed by value in ipmi_sel_oem_match() - CID#1261347

Browse Source 
Pass struct as a pointer instead.
This commit is contained in:
Zdenek Styblik 2015-01-22 06:21:54 +01:00
parent aabd9eb1ac
commit 88891f69d6
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
lib/ipmi_sel.c
View File

@ -92,21 +92,21 @@ static int ipmi_sel_oem_readval(char *str)
* helps make the code easier to read.
*/
static int
ipmi_sel_oem_match(uint8_t *evt, struct ipmi_sel_oem_msg_rec rec)
ipmi_sel_oem_match(uint8_t *evt, const struct ipmi_sel_oem_msg_rec *rec)
{
if (evt[2] == rec.value[SEL_BYTE(3)]
&& ((rec.value[SEL_BYTE(4)] < 0)
|| (evt[3] == rec.value[SEL_BYTE(4)]))
&& ((rec.value[SEL_BYTE(5)] < 0)
|| (evt[4] == rec.value[SEL_BYTE(5)]))
&& ((rec.value[SEL_BYTE(6)] < 0)
|| (evt[5] == rec.value[SEL_BYTE(6)]))
&& ((rec.value[SEL_BYTE(7)] < 0)
|| (evt[6] == rec.value[SEL_BYTE(7)]))
&& ((rec.value[SEL_BYTE(11)] < 0)
|| (evt[10] == rec.value[SEL_BYTE(11)]))
&& ((rec.value[SEL_BYTE(12)] < 0)
|| (evt[11] == rec.value[SEL_BYTE(12)]))) {
if (evt[2] == rec->value[SEL_BYTE(3)]
&& ((rec->value[SEL_BYTE(4)] < 0)
|| (evt[3] == rec->value[SEL_BYTE(4)]))
&& ((rec->value[SEL_BYTE(5)] < 0)
|| (evt[4] == rec->value[SEL_BYTE(5)]))
&& ((rec->value[SEL_BYTE(6)] < 0)
|| (evt[5] == rec->value[SEL_BYTE(6)]))
&& ((rec->value[SEL_BYTE(7)] < 0)
|| (evt[6] == rec->value[SEL_BYTE(7)]))
&& ((rec->value[SEL_BYTE(11)] < 0)
|| (evt[10] == rec->value[SEL_BYTE(11)]))
&& ((rec->value[SEL_BYTE(12)] < 0)
|| (evt[11] == rec->value[SEL_BYTE(12)]))) {
return 1;
} else {
return 0;
@ -198,7 +198,7 @@ static void ipmi_sel_oem_message(struct sel_event_record * evt, int verbose)
int i, j;
for (i=0; i < sel_oem_nrecs; i++) {
if (ipmi_sel_oem_match((uint8_t *)evt, sel_oem_msg[i])) {
if (ipmi_sel_oem_match((uint8_t *)evt, &sel_oem_msg[i])) {
printf (csv_output ? ",\"%s\"" : " | %s", sel_oem_msg[i].text);
for (j=4; j<17; j++) {
if (sel_oem_msg[i].value[SEL_BYTE(j)] == -3) {