From 4e220bebb075b432df474183c50170f5ea12641e Mon Sep 17 00:00:00 2001 From: Petter Reinholdtsen Date: Sat, 11 Jan 2014 06:45:44 +0000 Subject: [PATCH] Check return value from open() in ipmi_start_daemon() (Coverity CID CID 1148983). --- ipmitool/lib/helper.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ipmitool/lib/helper.c b/ipmitool/lib/helper.c index 546c760..4b903b0 100644 --- a/ipmitool/lib/helper.c +++ b/ipmitool/lib/helper.c @@ -44,6 +44,7 @@ #include #include #include +#include #if HAVE_CONFIG_H # include @@ -663,9 +664,10 @@ ipmi_start_daemon(struct ipmi_intf *intf) close(fd); } - open("/dev/null", O_RDWR); - dup(0); - dup(0); + fd = open("/dev/null", O_RDWR); + assert(0 == fd); + dup(fd); + dup(fd); } /* is_fru_id - wrapper for str-2-int FRU ID conversion. Message is printed