From 2579bbe54290b332505e26db8d2ed4b9d01936c3 Mon Sep 17 00:00:00 2001 From: Carol Hebert Date: Sat, 31 Jan 2009 01:10:18 +0000 Subject: [PATCH] Fix endian bug in SDR add from file reported in Tracker Bug #2075258 --- ipmitool/lib/ipmi_sdr.c | 2 +- ipmitool/lib/ipmi_sdradd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ipmitool/lib/ipmi_sdr.c b/ipmitool/lib/ipmi_sdr.c index df48442..e06a4bd 100644 --- a/ipmitool/lib/ipmi_sdr.c +++ b/ipmitool/lib/ipmi_sdr.c @@ -4073,7 +4073,7 @@ ipmi_sdr_dump_bin(struct ipmi_intf *intf, const char *ofile) uint8_t h[5]; /* build and write sdr header */ - h[0] = sdrr->id & 0xff; + h[0] = sdrr->id & 0xff; // LS Byte first h[1] = (sdrr->id >> 8) & 0xff; h[2] = sdrr->version; h[3] = sdrr->type; diff --git a/ipmitool/lib/ipmi_sdradd.c b/ipmitool/lib/ipmi_sdradd.c index 5f2b501..ec2cadf 100644 --- a/ipmitool/lib/ipmi_sdradd.c +++ b/ipmitool/lib/ipmi_sdradd.c @@ -352,7 +352,7 @@ ipmi_sdr_read_records(const char *filename, struct sdrr_queue *queue) rc = -1; break; } - sdrr->id = (binHdr[0] << 8) | binHdr[1]; + sdrr->id = (binHdr[1] << 8) | binHdr[0]; // LS Byte first sdrr->version = binHdr[2]; sdrr->type = binHdr[3]; sdrr->length = binHdr[4];