From 2302e83db519a641cf36d6f70b9d9b833815c23e Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Sun, 7 Jul 2013 11:58:13 +0000 Subject: [PATCH] ID: 28 - 'lib/ipmi_delloem.c' - clean up the code ipmi_lcd_set_single_line_text - invalid retval - Return (-1) on error as specified instead of 1. --- ipmitool/lib/ipmi_delloem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipmitool/lib/ipmi_delloem.c b/ipmitool/lib/ipmi_delloem.c index ae20a0d..629b46a 100644 --- a/ipmitool/lib/ipmi_delloem.c +++ b/ipmitool/lib/ipmi_delloem.c @@ -1242,7 +1242,7 @@ ipmi_lcd_set_single_line_text(struct ipmi_intf * intf, char * text) int rc = 0; if (bytes_to_store > IPMI_DELL_LCD_STRING_LENGTH_MAX) { lprintf(LOG_ERR, "Out of range Max limit is 62 characters"); - return 1; + return (-1); } else { bytes_to_store = MIN(bytes_to_store, IPMI_DELL_LCD_STRING_LENGTH_MAX); for (ii = 0; ii < 4; ii++) {